Open
Conversation
satyarohith
approved these changes
Nov 2, 2024
Member
satyarohith
left a comment
satyarohith
left a comment
There was a problem hiding this comment.
I agree! Let's remove it.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes
--staticflag from args as it's not documented and always enabled.There is a rare use case though where we want to skip uploading local files; when deploying a remote script that doesn't depend on any local assets. This might be better represented as
--remoteor--no-upload-local-filesflag, or we could also use--excludeoption to not upload local files at all. Let's revisit the necessity of additional flag like--remotewhen it turns out that this use case is really wanted.